[C2hs] c2hs + language.c

[Benedikt Huber]

On 24.01.2009, at 21:56, Duncan Coutts wrote:
> Capital.c and Capital.chs both #include "capital.h"
>
> Changing both to #include "Capital.h" makes the test work.
>
>> I'm on a case-insensitive filesystem though (sigh), so maybe some
>> darcs confusion.
>
> Ah, that'd explain things.
I should switch to a case-sensitive system for testing, really.

>> Could you please review (very small changes) and apply the following
>> patches, too ? Just to ensure c2hs will work with the next release of
>> language.c as well (stays compatible with 0.3.1).
>
> Ah, sorry, they depend on the patch:
>
> Fri Aug 15 20:09:07 BST 2008  benedikt.huber at gmail.com
>  * Version.hs: add note that this is a patched version using  
> Language.C
>
> which I did not apply since it didn't make sense for the mainline
> version.
>
> Would you mind re-sending the patches after pulling the latest patches
> from the mainline c2hs repo?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: update.dpatch
Type: application/octet-stream
Size: 25895 bytes
Desc: not available
Url : http://www.haskell.org/pipermail/c2hs/attachments/20090125/37779cf5/update-0001.obj
-------------- next part --------------



This patch also contains the missing files for the system tests.

> As for the content of the patches it looks fine. What happened to
> CAsmExt?
Oh, the arity of the constructor changes from 1 to 2. In language- 
c-0.3.1, CAsmExt
doesn't carry any information.

> Yes it's nice to finally get the C parser back again :-).
>
> BTW, I can't help flinching at names like CDeclExt, CThis, CThat etc
> (yes I know they were that way in c2hs originally). Next time you make
> an API break would you consider using names designed for qualified
> import? like C.DeclExt etc?

Usually I prefer qualified import too, and yes, this should be  
considered.
But probably not before the analysis module is a little bit more stable.

benedikt