darcs patch: fix and simplify ghci024 (was: validate breaks!)
mnislaih at gmail.com
Thu Nov 15 04:27:58 EST 2007
On 14/11/2007, at 20:43, Claus Reinke wrote:
>> Claus, is this expected to work with 6.8 ?
>> There is no ':show languages' option there, so the test fails.
> i should have said STABLE branch, i guess.
The test passes in STABLE branch. I'll be pushing asap.
> but this raises a question for those tests referring to
> features and fixes that have been merged into STABLE after release:
> should those tests be disabled for <=6.8.1?
>> It passes fine with HEAD here.
>> On 14/11/2007, at 14:48, Claus Reinke wrote:
>>>> I'm testing the fix now. Claus, I'm not very fluent with Python,
>>>> care if I send you the patch to ghci024.py for revision?
>>> what little i know of python, i learned for this testsuite!-)
>>> (very odd-feeling language - as if someone had taken perl,
>>> and systematically removed all the features i like; so my
>>> usage is probably very un-idiomatic..)
>>> since ghc 6.9 and 6.8 flags appear to be diverging rapidly, i've
>>> taken the liberty to simplify ghci024.py, to make future edits
>>> i've included Pepe's fixes and accounted for the different
>>> default for -fprint-bind-result in 6.8, assuming that is not
>>> going to be merged (Ian?).
>>> the test now runs clean on a recent head. could someone
>>> please verify with 6.8, and apply this testsuite patch?
>>> Wed Nov 14 13:00:43 GMT Standard Time 2007 claus.reinke at talk21.com
>>> * simplify ghci024.py, fix -fprint-bind-result, -fno-ignore-
>>> breakpoints, -fprint-bind-contents
>>> - as ghc 6.9 flags are beginning to diverge, we need
>>> a simpler way of specifying version-specific flags
>>> or settings: have two entirely separate sections,
>>> instead of one section with too many patches.
>>> even if that doubles the script size, it should
>>> be easier to edit. also add a warning that
>>> ghci024.stdout is a generated file.
>>> - default for -fprint-bind-result has changed
>>> - -fno-ignore-breakpoints is gone
>>> - -fprint-bind-contents is new
>>> M ./tests/ghc-regress/ghci/scripts/ghci024.py -11 +112
>>> M ./tests/ghc-regress/ghci/scripts/ghci024.script +1
More information about the Cvs-ghc