patch applied (ghc): Set -Wall -fno-warn-name-shadowing in compiler/ when stage /= 2

[Ian Lynagh]

On Mon, Sep 03, 2007 at 11:07:30AM +0100, Simon Peyton-Jones wrote:
> | > Sat Sep  1 04:30:18 PDT 2007  Ian Lynagh <igloo at earth.li>
> | >   * Set -Wall -fno-warn-name-shadowing in compiler/ when stage /= 2
> |
> | I mean when stage /= 1.
> 
> Any reason why /= 1?  Why not always?

To avoid failures caused by erroneous warnings in old GHCs. Although
given most of the time validate will be using the most recent released
GHC, maybe turning warnings on for stage 1 too would be worthwhile so
that if it's going to fall over it does so quickly. I'm happy either
way.

It's a pity there isn't a -Wwarn flag, so we can't easily negate -Werror
in GhcStage1Opts (or whatever it's called) only. I should add one now so
that in the future we won't have the same problem.


Thanks
Ian