Simplifier tests (was Re: patch applied (testsuite): Add a new category of "eyeball" tests)

Ian Lynagh igloo at earth.li
Sun Feb 10 15:44:23 EST 2008


On Fri, Feb 08, 2008 at 02:22:28PM +0000, Simon Peyton-Jones wrote:
> 
> | Right, if we used pcre-light then it wouldn't be tested when validating,
> | as pcre-light isn't a bootlib. Also, if that's a C wrapper then it's
> | probably more hassle for people on Windows than a Haskell regex library
> | would be.
> |
> | For the examples you listed, it looks to me like isInfixOf, filter,
> | length etc would suffice, though. Writing a Python script to do it is
> | another option.
> 
> it'd be ok for the eyeball tests to be omitted on validation.  They
> may well wobble around too, and it'd be good not to expose validators
> to that

I would have thought that the tests could be made reasonably robust, so
that if you were making a patch that caused the test to wobble then 99%
of the time you'd want to check any of these tests that fail, to confirm
you hadn't regressed something.


Thanks
Ian



More information about the Cvs-ghc mailing list