darcs patch: fix #1839, #1463, by supporting ghc-pkg bulkqueries
with substring matching
Simon Marlow
simonmarhaskell at gmail.com
Thu Jan 3 06:41:12 EST 2008
Claus Reinke wrote:
>>> register, update, FlagGlobalConfig, FlagConfig
>>>
>>> but all of these seem to expect exactly one file, to be stored in a
>>> single FilePath? am i missing something,
>>> or was this a wild goose chase?-)
>>
>> Just turn off self-globbing for ghc-pkg. Anyone using a sensible
>> shell (i.e. bash) will still get globbing anyway. I'd be surprised if
>> anyone at all notices.
>
> ok. i don't like excluding users needlessly, but the ghc-pkg commands
> don't seem to be prepared for globbing anyway, so the machinery for
> enabling selective self-globbing in ghc-pkg is in place, but commented
> out (to make validate happier) until someone needs it and decides where
> to provide it.
>
> oddly, i couldn't find a configure.mk variable pointing to the
> mingw location (there are several programs from there, ar, ld,
> and distrib/prep-bindist-mingw makes its own guesses), so i
> used an explicit path in Makefile, which should probably be
> fixed. perhaps you'd like to integrate the glob.hs/CRT_noglob.o combo
> into ghc proper, as an option for other ghc-compiled
> wanting to use '*' on windows? i leave that to you.
To finish off this patch we need a configure test that looks for
CRT_noglob.o, or alternatively looks for the mingw location. Also I would
leave out glob.hs, as it isn't required. The rest of the patch looks fine
to me.
Cheers,
Simon
More information about the Cvs-ghc
mailing list