darcs patch: more portabilization
Isaac Dupree
isaacdupree at charter.net
Wed Jan 16 18:49:11 EST 2008
Ian Lynagh wrote:
> Hi Isaac,
>
> On Sat, Jan 05, 2008 at 07:38:34PM -0500, Isaac Dupree wrote:
>> okay, this is a bunch but not all of the work. I'd like to have another
>> set of eyes look over it before committing, is all.
>
> Great stuff! Looks good to me, feel free to push (assuming it
> validates).
argh! conflicts!
including I noticed
what is this with part of FastTypes being split off into FastBool?
* Fix warnings in utils/FastTypes
Split off a FastBool module, to avoid a circular import with Panic
FastTypes doesn't import Panic
although
compiler/main/TidyPgm.lhs:import FastBool hiding ( fastOr )
compiler/nativeGen/MachCodeGen.hs:import FastBool (
isFastTrue )
compiler/nativeGen/RegAllocInfo.hs:import FastBool
compiler/nativeGen/MachRegs.lhs:import FastBool
oh, darnit, you wanted to panic for invalid FastBools... which seems
reasonable and hard to work around. (although: if the code typechecks
with FastBool=Bool, then I don't think it's possible to happen? Or do
ghci / GHC API make it more complicated? yes I guess they do.)
Alright, I suppose there's no problem supporting FastBool, just more
amending attempts
~Isaac
More information about the Cvs-ghc
mailing list