darcs patch: more portabilization
isaacdupree at charter.net
Wed Jan 16 19:16:19 EST 2008
Isaac Dupree wrote:
> Isaac Dupree wrote:
>> oh, darnit, you wanted to panic for invalid FastBools... which seems
>> reasonable and hard to work around.
> although if they're really supposed to be Fast, I question putting any
> extra checks than "is it equal to zero or not" for example, even to
> panic. chr# doesn't do checks the way Data.Char.chr does, so my fastChr
> doesn't do checks either, so that my patch would preserve GHC's speed.
> In fact that might make FastBool slower than Bool... maybe FastBool is
> not needed anyway and can be eliminated from the few places it's used?
okay, I'll do #ifdef DEBUG for the FastBool checks and leave it in a
separate module (I will make sure there are no warnings in either case!)
More information about the Cvs-ghc