darcs patch: Fix warnings (part 1)

Ian Lynagh igloo at earth.li
Wed Jan 30 07:06:02 EST 2008


Hi Twan,

On Sun, Jan 27, 2008 at 03:06:05AM +0100, Twan van Laarhoven wrote:
> 
> I have been fixing warnings in the GHC source code.

Great stuff, I've applied your patches.

I'm a little bit suspicious of (not your change, but the original code)

hunk ./compiler/coreSyn/CoreSyn.lhs 670
-seqAlts ((c,bs,e):alts) = seqBndrs bs `seq` seqExpr e `seq` seqAlts alts
+seqAlts ((_,bs,e):alts) = seqBndrs bs `seq` seqExpr e `seq` seqAlts alts

as I can't see a reason not to at least seq c.


Thanks
Ian



More information about the Cvs-ghc mailing list