patch applied (ghc): Big collection of patches for the new codegen
dias at eecs.harvard.edu
Wed Nov 26 00:22:28 EST 2008
Mon Oct 13 06:25:56 PDT 2008 dias at eecs.harvard.edu
* Big collection of patches for the new codegen branch.
o Fixed bug that emitted the copy-in code for closure entry
in the wrong place -- at the initialization of the closure.
o Refactored some of the closure entry code.
o Added code to check that no LocalRegs are live-in to a procedure
-- trip up some buggy programs earlier
o Fixed environment bindings for thunks
-- we weren't (re)binding the free variables in a thunk
o Fixed a bug in proc-point splitting that dropped some updates
to the entry block in a procedure.
o Fixed improper calls to code that generates CmmLit's for strings
o New invariant on cg_loc in CgIdInfo: the expression is always tagged
o Code to load free vars on entry to a thunk was (wrongly) placed before
the heap check.
o Some of the StgCmm code was redundantly passing around Id's
along with CgIdInfo's; no more.
o Initialize the LocalReg's that point to a closure before allocating and
initializing the closure itself -- otherwise, we have problems with
recursive closure bindings
o BlockEnv and BlockSet types are now abstract.
o Update frames:
- push arguments in Old call area
- keep track of the return sp in the FCode monad
- keep the return sp in every call, tail call, and return
(because it might be different at different call sites,
e.g. tail calls to the gc after a heap check are performed
before pushing the update frame)
- set the sp appropriately on returns and tail calls
o Reduce call, tail call, and return to a single LastCall node
o Added slow entry code, using different calling conventions on entry and tail call
o More fixes to the calling convention code.
The tricky stuff is all about the closure environment: it must be passed in R1,
but in non-closures, there is no such argument, so we can't treat all arguments
the same way: the closure environment is special. Maybe the right step forward
would be to define a different calling convention for closure arguments.
o Let-no-escapes need to be emitted out-of-line -- otherwise, we drop code.
o Respect RTS requirement of word alignment for pointers
My stack allocation can pack sub-word values into a single word on the stack,
but it wasn't requiring word-alignment for pointers. It does now,
by word-aligning both pointer registers and call areas.
o CmmLint was over-aggresively ruling out non-word-aligned memory references,
which may be kosher now that we can spill small values into a single word.
o Wrong label order on a conditional branch when compiling switches.
o void args weren't dropped in many cases.
To help prevent this kind of mistake, I defined a NonVoid wrapper,
which I'm applying only to Id's for now, although there are probably
other good candidates.
o A little code refactoring: separate modules for procpoint analysis splitting,
stack layout, and building infotables.
o Stack limit check: insert along with the heap limit check, using a symbolic
constant (a special CmmLit), then replace it when the stack layout is known.
o Removed last node: MidAddToContext
o Adding block id as a literal: means that the lowering of the calling conventions
no longer has to produce labels early, which was inhibiting common-block elimination.
Will also make it easier for the non-procpoint-splitting path.
o Info tables: don't try to describe the update frame!
o Over aggressive use of NonVoid!!!!
Don't drop the non-void args before setting the type of the closure!!!
o Sanity checking:
Added a pass to stub dead dead slots on the stack
(only ~10 lines with the dataflow framework)
o More sanity checking:
Check that incoming pointer arguments are non-stubbed.
Note: these checks are still subject to dead-code removal, but they should
still be quite helpful.
o Better sanity checking: why stop at function arguments?
Instead, in mkAssign, check that _any_ assignment to a pointer type is non-null
-- the sooner the crash, the easier it is to debug.
Still need to add the debugging flag to turn these checks on explicitly.
o Fixed yet another calling convention bug.
This time, the calls to the GC were wrong. I've added a new convention
for GC calls and invoked it where appropriate.
We should really straighten out the calling convention stuff:
some of the code (and documentation) is spread across the compiler,
and there's some magical use of the node register that should really
be handled (not avoided) by calling conventions.
o Switch bug: the arms in mkCmmLitSwitch weren't returning to a single join point.
o Environment shadowing problem in Stg->Cmm:
When a closure f is bound at the top-level, we should not bind f to the
node register on entry to the closure.
Why? Because if the body of f contains a let-bound closure g that refers
to f, we want to make sure that it refers to the static closure for f.
Normally, this would all be fine, because when we compile a closure,
we rebind free variables in the environment. But f doesn't look like
a free variable because it's a static value. So, the binding for f
remains in the environment when we compile g, inconveniently referring
to the wrong thing.
Now, I bind the variable in the local environment only if the closure is not
bound at the top level. It's still okay to make assumptions about the
node holding the closure environment; we just won't find the binding
in the environment, so code that names the closure will now directly
get the label of the static closure, not the node register holding a
pointer to the static closure.
o Don't generate bogus Cmm code containing SRTs during the STG -> Cmm pass!
The tables made reference to some labels that don't exist when we compute and
generate the tables in the back end.
o Safe foreign calls need some special treatment (at least until we have the integrated
codegen). In particular:
o they need info tables
o they are not procpoints -- the successor had better be in the same procedure
o we cannot (yet) implement the calling conventions early, which means we have
to carry the calling-conv info all the way to the end
o We weren't following the old convention when registering a module.
Now, we use update frames to push any new modules that have to be registered
and enter the youngest one on the stack.
We also use the update frame machinery to specify that the return should pop
the return address off the stack.
o At each safe foreign call, an infotable must be at the bottom of the stack,
and the TSO->sp must point to it.
o More problems with void args in a direct call to a function:
We were checking the args (minus voids) to check whether the call was saturated,
which caused problems when the function really wasn't saturated because it
took an extra void argument.
o Forgot to distinguish integer != from floating != during Stg->Cmm
o Updating slotEnv and areaMap to include safe foreign calls
The dataflow analyses that produce the slotEnv and areaMap give
results for each basic block, but we also need the results for
a safe foreign call, which is a middle node.
After running the dataflow analysis, we have another pass that
updates the results to includ any safe foreign calls.
o Added a static flag for the debugging technique that inserts
instructions to stub dead slots on the stack and crashes when
a stubbed value is loaded into a pointer-typed LocalReg.
o C back end expects to see return continuations before their call sites.
Sorted the flowgraphs appropriately after splitting.
o PrimOp calling conventions are special -- unlimited registers, no stack
Yet another calling convention...
o More void value problems: if the RHS of a case arm is a void-typed variable,
don't try to return it.
o When calling some primOp, they may allocate memory; if so, we need to
do a heap check when we return from the call.
M ./compiler/cmm/BlockId.hs -22 +108
M ./compiler/cmm/CLabel.hs -4 +16
M ./compiler/cmm/Cmm.hs -2 +8
M ./compiler/cmm/CmmBrokenBlock.hs -1 +1
M ./compiler/cmm/CmmCPS.hs -11 +12
M ./compiler/cmm/CmmCPSZ.hs -23 +77
M ./compiler/cmm/CmmCallConv.hs -30 +49
M ./compiler/cmm/CmmCommonBlockElimZ.hs -41 +50
M ./compiler/cmm/CmmContFlowOpt.hs -39 +43
M ./compiler/cmm/CmmCvt.hs -25 +24
M ./compiler/cmm/CmmExpr.hs -9 +28
M ./compiler/cmm/CmmInfo.hs -2 +23
M ./compiler/cmm/CmmLint.hs -11 +1
M ./compiler/cmm/CmmLive.hs -11 +11
M ./compiler/cmm/CmmLiveZ.hs -16 +24
M ./compiler/cmm/CmmOpt.hs -1 +2
M ./compiler/cmm/CmmParse.y -7 +7
M ./compiler/cmm/CmmProcPoint.hs -8 +8
M ./compiler/cmm/CmmProcPointZ.hs -565 +120
M ./compiler/cmm/CmmSpillReload.hs -75 +60
M ./compiler/cmm/CmmZipUtil.hs -2 +1
M ./compiler/cmm/DFMonad.hs -4 +3
M ./compiler/cmm/MkZipCfg.hs -26 +36
M ./compiler/cmm/MkZipCfgCmm.hs -58 +86
M ./compiler/cmm/OptimizationFuel.hs -2 +3
M ./compiler/cmm/PprC.hs +8
M ./compiler/cmm/PprCmm.hs -15 +11
M ./compiler/cmm/PprCmmZ.hs -16 +6
M ./compiler/cmm/StackColor.hs -2 +2
M ./compiler/cmm/ZipCfg.hs -29 +53
M ./compiler/cmm/ZipCfgCmmRep.hs -123 +114
M ./compiler/cmm/ZipCfgExtras.hs -2 +2
M ./compiler/cmm/ZipDataflow.hs -32 +45
M ./compiler/codeGen/CgInfoTbls.hs -3 +3
M ./compiler/codeGen/StgCmm.hs -51 +30
M ./compiler/codeGen/StgCmmBind.hs -141 +179
M ./compiler/codeGen/StgCmmClosure.hs -29 +42
M ./compiler/codeGen/StgCmmCon.hs -11 +15
M ./compiler/codeGen/StgCmmEnv.hs -24 +47
M ./compiler/codeGen/StgCmmExpr.hs -45 +79
M ./compiler/codeGen/StgCmmForeign.hs -70 +57
M ./compiler/codeGen/StgCmmHeap.hs -47 +85
M ./compiler/codeGen/StgCmmLayout.hs -32 +78
M ./compiler/codeGen/StgCmmMonad.hs -34 +69
M ./compiler/codeGen/StgCmmPrim.hs -3 +5
M ./compiler/codeGen/StgCmmProf.hs -2 +3
M ./compiler/codeGen/StgCmmUtils.hs -18 +24
M ./compiler/ghc.cabal.in +2
M ./compiler/main/HscMain.lhs -11 +15
M ./compiler/main/StaticFlagParser.hs +1
M ./compiler/main/StaticFlags.hs +3
M ./compiler/nativeGen/MachRegs.lhs +2
M ./compiler/nativeGen/PprMach.hs -1 +1
M ./compiler/nativeGen/RegAllocLinear.hs -8 +7
M ./compiler/nativeGen/RegLiveness.hs -15 +15
M ./compiler/nativeGen/RegSpillCost.hs -1 +2
View patch online:
More information about the Cvs-ghc