patch applied (ghc): Fixed ThreadID to be defined as StgThreadID, not StgWord64. Changed CapabilityNum to CapNo. Added helper functions postCapNo() and postThreadID().

Donnie Jones donnie at darthik.com
Wed Apr 22 23:08:51 EDT 2009


Hello Simon,

I unrecorded this patch from my local repository, and this is a new
patch with the previous changes but does not change the type of
ThreadID.

I'm a little leary of my darcs' skills... but, hopefully this fixes
the issue.  :)
Please let me know if there are any issues with my patch.
Thank you.
--
Donnie Jones

On Mon, Apr 20, 2009 at 6:32 AM, Simon Marlow <marlowsd at gmail.com> wrote:
> Ian Lynagh wrote:
>>
>> Sun Apr 12 18:07:05 PDT 2009  donnie at darthik.com
>>  * Fixed ThreadID to be defined as StgThreadID, not StgWord64.  Changed
>> CapabilityNum to CapNo.  Added helper functions postCapNo() and
>> postThreadID().
>>  Ignore-this: dde2f442f9d5e43f20f52069dee4f8c0
>>  ThreadID was StgWord64, but should have been StgThreadID, which is
>>  currently StgWord32.  Changed name from CapabilityNum to CapNo to better
>>  reflect naming in Capability struct where "no" is the capability number.
>>  Modified EventLog.c to use the helper functions postCapNo() and
>>  postThreadID () for CapNo and ThreadID.
>
> Donnie: this changes the event log file format, which is something we're
> trying not to do.  The thread Ids are 64 bits on purpose: since you can
> allocate a thread in ~6us, you could run out of thread Ids in about 7 hours
> with only 32 bits.  The fact that the RTS itself uses 32 bits to store
> thread Ids is really a bug - I'm fairly sure it used to be 64 bits, I'll
> look into why it was changed.
>
> Cheers,
>        Simon
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: eventlog-revert-threadid-renamed-capabilitynum-to-capno.dpatch
Type: application/octet-stream
Size: 225283 bytes
Desc: not available
Url : http://www.haskell.org/pipermail/cvs-ghc/attachments/20090422/456a1e39/eventlog-revert-threadid-renamed-capabilitynum-to-capno-0001.obj


More information about the Cvs-ghc mailing list