patch applied (ghc): Use /usr/bin/test if it exists, and fix test syntax.

Matthias Kilian kili at outback.escape.de
Thu Jul 9 14:39:22 EDT 2009


On Thu, Jul 09, 2009 at 08:47:23AM -0700, Simon Marlow wrote:
> Thu Jul  9 05:46:16 PDT 2009  Simon Marlow <marlowsd at gmail.com>
>   * Use /usr/bin/test if it exists, and fix test syntax.
>   Ignore-this: 83a75ba7c3ce2a1d02bddb7bfe414bfe
>   Should fix Solaris build failures
> 
>     M ./Makefile -2 +7
> 
> View patch online:
> http://darcs.haskell.org/ghc/_darcs/patches/20090709124616-12142-e5559678c1780a0fc5f8b43cd3f552557664595c.gz

Ugh. Not that it's very important, but if solaris supports `test
-f file' and/or `[ -f file ]' (which it should), the following
pattern rule may be slightly more readable:

%.old: %
	@set -x && [ -f $@ ] && cmp -s $< $@ || cp -p $< $@
	touch $@

And then simply change the `$(REALGOALS) all' rule to

$(REALGOALS) all:	mk/config.mk mk/project.mk compiler/ghc.cabal
	@echo  "===--- updating makefiles phase 0"
	...

Of course, that should be tested first ;-)

Ciao,
	Kili

ps: the `@set -x && ...' hack just helps to see what exactly is
done in the first command.



More information about the Cvs-ghc mailing list