Validate failure

[Simon Marlow]

On 04/11/2009 23:17, Roman Leshchinskiy wrote:
> On 05/11/2009, at 02:45, Simon Marlow wrote:
>
>> "inplace/bin/ghc-cabal" configure
>> --with-ghc="/64playpen/simonmar/validate/inplace/bin/dummy-ghc"
>> --with-ghc-pkg="/64playpen/simonmar/validate/inplace/bin/ghc-pkg"
>> --with-gcc="/usr/bin/gcc" --configure-option=--with-cc="/usr/bin/gcc"
>> --enable-shared
>> --with-hscolour="/home/simonmar/fp/bin/x86_64-unknown-linux/HsColour"
>> --configure-option=CFLAGS="-Wall " --configure-option=LDFLAGS=" " --
>> dist-install libraries/dph/dph-seq
>> Configuring dph-seq-0.4.0...
>> ghc-cabal: At least the following dependencies are missing:
>> ghc -any
>>
>>
>> I think we lack some ordering constraints when configuring packages?
>
> Hmm, I've looked around but I don't see where to add them. In ghc.mk, we
> have this:
>
> # We cannot run ghc-cabal to configure a package until we have
> # configured and registered all of its dependencies. So the following
> # hack forces all the configure steps to happen in exactly the order
> # given in the PACKAGES variable above. Ideally we should use the
> # correct dependencies here to allow more parallelism, but we don't
> # know the dependencies until we've generated the pacakge-data.mk
> # files.
> define fixed_pkg_dep
> libraries/$1/$2/package-data.mk : $$(GHC_PKG_INPLACE) $$(if
> $$(fixed_pkg_prev),libraries/$$(fixed_pkg_prev)/$2/package-data.mk)
> fixed_pkg_prev:=$1
> endef
>
> ifneq "$(BINDIST)" "YES"
> fixed_pkg_prev=
> $(foreach pkg,$(PACKAGES) $(PACKAGES_STAGE2),$(eval $(call
> fixed_pkg_dep,$(pkg),dist-install)))
>
> Note that PACKAGES_STAGE2 (that's DPH) comes after PACKAGES which should
> include ghc? I thought that would be sufficient but if it's not I don't
> know where else to look. Also, it's strange that the configure order is
> system dependent as I'm not getting this failure.

I fixed it:

Thu Nov  5 02:30:25 PST 2009  Simon Marlow <marlowsd at gmail.com>
   * Get the package-data.mk dependencies right

PACKAGES doesn't include ghc, mainly because ghc doesn't follow the same 
layout as the other packages.

Cheers,
	Simon