darcs patch: Don't try to redefine ELF types
marlowsd at gmail.com
Mon Nov 9 08:58:09 EST 2009
On 08/11/2009 19:14, Matthias Kilian wrote:
> On Sun, Nov 08, 2009 at 08:08:12PM +0100, Matthias Kilian wrote:
>> Date: Sun, 8 Nov 2009 20:08:12 +0100 (CET)
>> Message-Id:<200911081908.nA8J8CwB031137 at nutty.outback.escape.de>
>> To: cvs-ghc at haskell.org
>> From: Matthias Kilian<kili at outback.escape.de>
>> Subject: darcs patch: Don't try to redefine ELF types
>> Sun Nov 8 18:48:50 CET 2009 Matthias Kilian<kili at outback.escape.de>
>> * Don't try to redefine ELF types
>> At least on OpenBSD, ELFCLASS and all the Elf_* and ELF_* stuff is
>> already defined (in sys/exec_elf.h, which is included from elf_abi.h).
>> Hopefully, using Elf_Addr as a sentinel is enough to not break the build
>> on other systems.
> Attention! This patch is of questionable use, since all it does for
> me is to avoid errors when the rts is built on one system for the
> creation of boot.tar.gz for another system, to create a hc file
> bundle. So it maybe completely pointless, and if someone wants to
> push it at all, please test a normal build (or ask others to test
> it) on other systems (at least Linuxes, maybe other BSDs) first.
Ok, I don't have a BSD box to test on right now, but I can validate on
Linux. Do you think it's important to get the patch in?
More information about the Cvs-ghc