darcs patch: Don't try to redefine ELF types
kili at outback.escape.de
Mon Nov 9 12:46:29 EST 2009
On Mon, Nov 09, 2009 at 01:58:09PM +0000, Simon Marlow wrote:
> >>Sun Nov 8 18:48:50 CET 2009 Matthias Kilian<kili at outback.escape.de>
> >> * Don't try to redefine ELF types
> >> At least on OpenBSD, ELFCLASS and all the Elf_* and ELF_* stuff is
> >> already defined (in sys/exec_elf.h, which is included from elf_abi.h).
> >> Hopefully, using Elf_Addr as a sentinel is enough to not break the
> >> build
> >> on other systems.
> >Attention! This patch is of questionable use, since all it does for
> >me is to avoid errors when the rts is built on one system for the
> >creation of boot.tar.gz for another system, to create a hc file
> >bundle. So it maybe completely pointless, and if someone wants to
> >push it at all, please test a normal build (or ask others to test
> >it) on other systems (at least Linuxes, maybe other BSDs) first.
> Ok, I don't have a BSD box to test on right now, but I can validate on
> Linux. Do you think it's important to get the patch in?
I can live without it. And since people are discussing shared
libraries again, it's probably not worth pushing -- after all, it
doesn't fix any real error.
More information about the Cvs-ghc