patch applied (ghc): Fix some cpp warnings when building on
FreeBSD; patch from Gabor PALI
kili at outback.escape.de
Wed Apr 28 17:19:27 EDT 2010
On Wed, Apr 28, 2010 at 09:16:33AM -0700, Ian Lynagh wrote:
> Wed Apr 28 08:07:00 PDT 2010 Ian Lynagh <igloo at earth.li>
> * Fix some cpp warnings when building on FreeBSD; patch from Gabor PALI
> M ./rts/Linker.c +8
WHat exactly does this fix? I've some similar patch around for some
time, but it #ifdef's the whole ELF stuff out (for OpenBSD).
Can you show me the warnings you get without it? And could you try to
wrap the whole ELF stuff within something like an #ifdef Elf_Addr? That
would be much more sane, IMHO.
Just #ifdef'ing out some lines that produce warnings (and not
mentioning any details in the log message) sounds like removing
warnings for the sake of removing warnings. We've seen this in the
past. Remember the Debian/OpenSSL disaster. Please don't zap
warnings without reason and without investigating. And if there's
a reason to zap warnings, please say so.
Sorry for nitpicking, but whenever I read `fix warnings' without a
detailed explanation I'm almost sure that something will break.
More information about the Cvs-ghc