darcs patch: libffi: install 'ffitarget.h' header as ... (and 1 more)

[Sergei Trofimovich]

> Thanks for the patch.
> 
> I'll need to modify it slightly - we can do better than converting to 
> Strings when comparing types, and I'll add some comments from your log 
> message.

Sure. Sounds perfect. My hack is the most i was able to do to workaround
libffi inconsistency.

> I'm also slightly concerned about the unconditional #include "ffi.h" 
> added to the stub files.  I'd like to understand more about why that's 
> needed.

"ffi.h" is needed only for 'ffi_arg' type here, so
a) it can be conditional under #ifdef USE_LIBFFI_FOR_ADJUSTORS but i
don't know what else is needed to export that define to _stub.c) or even
b) conditional in haskell code (but generating very different _stub files for various
ghc build types is a little scary. missing "ffitarget.h" installation was one of those
untested cases).

I did not bother as "ffi.h" is installed unconditionally in every type of ghc build.
And it was the easiest thing :)

Thank you for the review!

> Cheers,
> 	Simon

-- 

  Sergei
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
Url : http://www.haskell.org/pipermail/cvs-ghc/attachments/20100322/a24ae973/signature.bin