[GHC] #4419: dph tests fail with panic

Simon Peyton-Jones simonpj at microsoft.com
Wed Oct 20 09:20:31 EDT 2010


Could you add comments to the setUnfolingLazily thing to explain?  

| -----Original Message-----
| From: Roman Leshchinskiy [mailto:rl at cse.unsw.edu.au]
| Sent: 20 October 2010 12:23
| To: Simon Peyton-Jones
| Cc: Ian Lynagh; cvs-ghc at haskell.org
| Subject: Re: [GHC] #4419: dph tests fail with panic
| 
| On 20 Oct 2010, at 12:11, Simon Peyton-Jones <simonpj at microsoft.com> wrote:
| 
| > |  > But why do the Ids need an unfolding at all?  The simplifier will add one for
| itself, as
| > |  it does with ordinary Haskell code
| > |
| > |  Because we want to make some of the bindings we generate INLINE and IIUC, the
| way
| > |  to do this is to mkInlineUnfolding.
| >
| > Ah.  But do *all* of the Ids in a mutually recursive group get INLINE pragamas?  If
| so that sounds suspicious.  If not, you can cut the loop with the ones that don't
| 
| We give INLINE pragmas to closures produced by closure conversion but not (yet) to
| the functions themselves. Come to think of it, we could, of course, cut the loop but
| I decided to leave that to the simplifier since it has the mechanisms for this
| anyway.
| 
| Roman
| 
| 
| >



More information about the Cvs-ghc mailing list