[PATCH] Only add bare_flag to git clone args if non-empty

[David Peixotto]

The first patch has a bug. I was adding the --bare flag at each clone, so we were getting lots of --bare flags towards the end of the list. This new patch only adds it once.


On Jul 7, 2011, at 3:29 PM, David Peixotto wrote:

> Adding the bare_flag variable to the git args as an empty string was causing
> the git clone command to fail with a complaint about too many arguments. I
> think it was directly calling execv with the empty string as a fourth argument
> which caused git to complain. This patch only adds the flag as an argument to
> the git command if it is non-empty.
> 
> Without this patch I was getting a failure trying to sync after a fresh clone.
> 
>     $ ./sync-all get
>     == running git clone /Users/dave/Research/git/ghc/ghc-tarballs ghc-tarballs 
>     Too many arguments.
> 
>     git failed: 33024 at ./sync-all line 206.
> 
> 
> <0001-Only-add-bare_flag-to-git-clone-args-if-non-empty.patch>
> _______________________________________________
> Cvs-ghc mailing list
> Cvs-ghc at haskell.org
> http://www.haskell.org/mailman/listinfo/cvs-ghc

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/cvs-ghc/attachments/20110707/bf1a1204/attachment-0002.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Only-add-bare_flag-to-git-clone-args-if-non-empty.patch
Type: application/octet-stream
Size: 1284 bytes
Desc: not available
URL: <http://www.haskell.org/pipermail/cvs-ghc/attachments/20110707/bf1a1204/attachment-0001.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.haskell.org/pipermail/cvs-ghc/attachments/20110707/bf1a1204/attachment-0003.htm>