[commit: ghc] master: Without -O do not complain about SPECIALISE pragmas for non-INLINABLE things (d8d65a2)

[Michal Terepeta]

On 11.06 16:37, Ian Lynagh wrote:
> On Sat, Jun 11, 2011 at 03:31:59PM +0100, Ian Lynagh wrote:
> > On Sat, Jun 11, 2011 at 06:52:58AM -0700, Simon Peyton-Jones wrote:
> > > 
> > > +       ; dflags <- getDOpts
> > > +       ; if not (dopt Opt_Specialise dflags) then
> > > +            return []    -- Ignore SPECIALISE pragmas for imported things
> > > +	    	   	 -- when -O is not on; otherwise we get bogus 
> > > +			 -- complaints about lack of INLINABLE pragmas 
> > > +			 -- in the imported module (also compiled without -O)
> > > +			 -- Notably, when Haddocking the base library
> > 
> > Don't we actually want to ignore SPECIALISE pragmas if the module the
> > thing was imported from was compiled without -O, rather than if the
> > importing module is being compiled without -O?
> 
> Also, the build still seems to be failing with the same error.
> 
> 
> Thanks
> Ian

The patch from Simon doesn't seem to fix the issue for me either. And it
seems it can't --- the haddock is called (at least for me) with
"--optghc=-O" so testing for Opt_Specialise will return True. I've run
haddock by hand without optimization and as expected haddock doesn't
fail. So the questions are: why is haddock called with --optghc=-O and
why is it failing with it?

Thanks,
Michal