[commit: ghc] master: Implement regslot inlining, document soundness concerns. (ffd3bd8)

[Edward Z. Yang]

Ah, ghastly, I validated with a GHC later than 7.0.1, so I didn't see
these errors (it's due to insufficiently clever pattern matching
with GADTs, as I understand.)  I'm validating a new patch that should fix it.

Excerpts from Dimitrios Vytiniotis's message of Tue Jun 14 13:54:02 -0400 2011:
> I just got: 
> 
> compiler\cmm\CmmSpillReload.hs:92:11:
>     Warning: Pattern match(es) are non-exhaustive
>              In an equation for `first':
>                  Patterns not matched:
>                      (CmmComment _) _
>                      (CmmAssign _ _) _
>                      (CmmStore _ _) _
>                      (CmmUnsafeForeignCall _ _ _) _
>                      ...
> 
> compiler\cmm\CmmSpillReload.hs:114:23:
>     Warning: Pattern match(es) are non-exhaustive
>              In a case alternative:
>                  Patterns not matched:
>                      CmmEntry _
>                      CmmComment _
>                      CmmAssign _ _
>                      CmmStore _ _
>                      ...
> 
> compiler\cmm\CmmSpillReload.hs:135:11:
>     Warning: Pattern match(es) are non-exhaustive
>              In an equation for `first':
>                  Patterns not matched:
>                      (CmmComment _) _
>                      (CmmAssign _ _) _
>                      (CmmStore _ _) _
>                      (CmmUnsafeForeignCall _ _ _) _
>                      ...
> 
> <no location info>: 
> Failing due to -Werror.
> 
> make[1]: *** [compiler/stage1/build/CmmSpillReload.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [all] Error 2
> 
> Is this related to this patch? 
> 
> Thanks! 
> d-
> 
> > -----Original Message-----
> > From: cvs-ghc-bounces at haskell.org [mailto:cvs-ghc-bounces at haskell.org]
> > On Behalf Of Edward Z. Yang
> > Sent: 14 June 2011 18:22
> > To: cvs-ghc at haskell.org
> > Subject: [commit: ghc] master: Implement regslot inlining, document
> > soundness concerns. (ffd3bd8)
> > 
> > Repository : ssh://darcs.haskell.org//srv/darcs/ghc
> > 
> > On branch  : master
> > 
> > http://hackage.haskell.org/trac/ghc/changeset/ffd3bd85a6febeec05c99d0da
> > 7dfdf34cad59caf
> > 
> > >---------------------------------------------------------------
> > 
> > commit ffd3bd85a6febeec05c99d0da7dfdf34cad59caf
> > Author: Edward Z. Yang <ezyang at mit.edu>
> > Date:   Tue Jun 14 18:21:50 2011 +0100
> > 
> >     Implement regslot inlining, document soundness concerns.
> > 
> >     Signed-off-by: Edward Z. Yang <ezyang at mit.edu>
> > 
> >  compiler/cmm/CmmExpr.hs               |    5 +-
> >  compiler/cmm/CmmRewriteAssignments.hs |  147
> > ++++++++++++++++++++++++++++----
> >  compiler/cmm/CmmSpillReload.hs        |   14 ++-
> >  3 files changed, 141 insertions(+), 25 deletions(-)
> > 
> > 
> > Diff suppressed because of size. To see it, use:
> > 
> >     git show ffd3bd85a6febeec05c99d0da7dfdf34cad59caf
> > 
> > _______________________________________________
> > Cvs-ghc mailing list
> > Cvs-ghc at haskell.org
> > http://www.haskell.org/mailman/listinfo/cvs-ghc