[commit: ghc] master: Revert "Make more primops cheaper" (4a088f8)

Simon Peyton Jones simonpj at microsoft.com
Fri Apr 27 19:14:41 CEST 2012


Repository : ssh://darcs.haskell.org//srv/darcs/ghc

On branch  : master

http://hackage.haskell.org/trac/ghc/changeset/4a088f806736b8e7c55be334a946f134ba9a30b6

>---------------------------------------------------------------

commit 4a088f806736b8e7c55be334a946f134ba9a30b6
Author: Simon Peyton Jones <simonpj at microsoft.com>
Date:   Fri Apr 27 18:06:33 2012 +0100

    Revert "Make more primops cheaper"
    
    This reverts commit a365a58eade7cb2c961af8e60c20b7d78b1b7484.
    
    Sigh.  Seg fault.  Major sigh.

>---------------------------------------------------------------

 compiler/prelude/PrimOp.lhs |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/compiler/prelude/PrimOp.lhs b/compiler/prelude/PrimOp.lhs
index 02b6f0b..50803fb 100644
--- a/compiler/prelude/PrimOp.lhs
+++ b/compiler/prelude/PrimOp.lhs
@@ -450,8 +450,6 @@ primOpIsCheap op
      -- This is vital; see Note [PrimOp can_fail and has_side_effects]
  && not (primOpOutOfLine op)
 -- && primOpCodeSize op <= primOpCodeSizeDefault 
--- Omitting; it makes fft2 run a lot slower by preventing
---           eta expansion in an inner loop, with a primop cosDouble#
      -- The latter two conditions are a HACK; we should 
      -- really have a proper property on primops that says
      -- when they are cheap to execute.  For now we are using





More information about the Cvs-ghc mailing list