cvs commit: fptools/libraries/network/Network URI.hs

[Graham Klyne]

At 22:42 28/10/04 +0200, Sven Panne wrote:
>Graham Klyne wrote:
>>Oops, well spotted, thanks.  That's another small change I made 
>>recently.  I should have mentioned in the CVS comment, but forgot, that I 
>>changed the order of parameters to escapeString.  Does anyone have any 
>>objection?
>
>Yes, I do! :-) It breaks old programs and introduces just another #ifdef...

Ah, that's a good reason.  I've been working on this for so long now I 
forget which interfaces are new and which are old.

>>[[
>>diff -r1.13 -r1.12
>>95c95
>><     , escapeString              -- :: (Char->Bool) -> String -> String
>>---
>>  >     , escapeString              -- :: String -> (Char->Bool) -> String
>>]]
>>(Rationale:  the revised parameter order makes it easier to create 
>>specialized string-escape functions by currying with the 
>>escape-character-testing function.)
>
>I really like the new order much more and I've never understood the old one,
>to be honest. Nevertheless, I think we should keep the old version 
>(deprecated)
>and be creative about a new name for the version with swapped parameters 
>(incl.
>escapeChar). That's library business...

I suggest:

Create a new function escapeURIString with the character-test arg first

Define deprecated escapeString = flip escapeURIString

#g


------------
Graham Klyne
For email:
http://www.ninebynine.org/#Contact