patch applied (packages/bytestring): Remove INLINE pragmas on recursive functions

Don Stewart dons at galois.com
Mon Dec 8 21:23:54 EST 2008


Yep. All good. I found Duncan's conversation.

Thanks!

 Don

simonpj:
> I specifically discussed this with Duncan, and agreed that I'd push to this fork, while he did the mail branch.
> 
> S
> 
> | -----Original Message-----
> | From: Don Stewart [mailto:dons at galois.com]
> | Sent: 08 December 2008 23:46
> | To: Simon Peyton-Jones
> | Cc: cvs-libraries at haskell.org
> | Subject: Re: patch applied (packages/bytestring): Remove INLINE pragmas on
> | recursive functions
> |
> | simonpj:
> | > Fri Dec  5 09:04:52 PST 2008  simonpj at microsoft.com
> | >   * Remove INLINE pragmas on recursive functions
> | >
> | >   GHC now complains about INLINE pragmas on recursive functions,
> | >   and they were no-ops before in any case
> | >
> | >
> | >     M ./Data/ByteString.hs -1 +1
> | >     M ./Data/ByteString/Char8.hs -1
> | >     M ./Data/ByteString/Lazy/Char8.hs -1
> | >
> |
> | We need to somehow stop people pushing patches to the GHC fork of
> | bytestring, since it quickly leads to out-of-sync issues as patches do
> | not flow upstream to bytestring HQ. Time to make it read only?
> |
> | -- Don
> 
> 


More information about the Cvs-libraries mailing list