patch applied (packages/filepath): The current directory is ".",
not "" (GHC bug #2034) (patch version 2)
ndmitchell at gmail.com
Fri May 7 15:32:51 EDT 2010
I notice this is only a 1 line change. Have you updated the properties as well?
Have you run the QuickCheck test that ensures these properties are
still correct? The properties are both documentation and tests.
On Wed, May 5, 2010 at 1:48 PM, Simon Marlow <marlowsd at gmail.com> wrote:
> Wed Nov 4 01:51:09 PST 2009 Simon Marlow <marlowsd at gmail.com>
> * The current directory is ".", not "" (GHC bug #2034) (patch version 2)
> So now
> splitFileName "foo" = ("./", "foo")
> which gives us the additional property that
> > Valid x => isValid (fst (splitFileName x))
> This property is important, because it means that we can pass the
> result of takeDirectory to any of the functions in System.Directory,
> whereas previously we would have to check for the empty case first.
> After discussion on the libraries list, I removed the second part of
> the original change:
> "." </> x = x
> This small bit of normalisation was there to ensure that the property
> > Valid x => uncurry </> (splitFileName x) == x
> still held. However, it was arguably inconsistent (see the
> discussion). Now this property has an exception:
> > Valid x => uncurry (</>) (splitFileName x) == x || fst (splitFileName x) == "./"
> This is a small price to pay to gain the new property above.
> M ./System/FilePath/Internal.hs +1
> View patch online:
> Cvs-libraries mailing list
> Cvs-libraries at haskell.org
More information about the Cvs-libraries