[commit: Cabal] master: Packages are only invalid if they have more than zero problems. (5f1d555)

Ian Lynagh igloo at earth.li
Fri Jun 24 01:53:09 CEST 2011


Repository : ssh://darcs.haskell.org//srv/darcs/packages/Cabal

On branch  : master

http://hackage.haskell.org/trac/ghc/changeset/5f1d555f4b5e5639103a6f9cad0dfe9ecb33aa29

>---------------------------------------------------------------

commit 5f1d555f4b5e5639103a6f9cad0dfe9ecb33aa29
Author: Duncan Coutts <duncan at haskell.org>
Date:   Mon May 5 09:05:13 2008 +0000

    Packages are only invalid if they have more than zero problems.

>---------------------------------------------------------------

 cabal-install/Hackage/InstallPlan.hs |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/cabal-install/Hackage/InstallPlan.hs b/cabal-install/Hackage/InstallPlan.hs
index b2ac6d2..de4783e 100644
--- a/cabal-install/Hackage/InstallPlan.hs
+++ b/cabal-install/Hackage/InstallPlan.hs
@@ -291,8 +291,10 @@ showPlanProblem (PackageInconsistency name inconsistencies) =
 problems :: OS -> Arch -> CompilerId
          -> PackageIndex (PlanPackage a) -> [PlanProblem a]
 problems os arch comp index =
-     [ PackageInvalid pkg (configuredPackageProblems os arch comp pkg)
-     | Configured pkg <- PackageIndex.allPackages index ]
+     [ PackageInvalid pkg packageProblems
+     | Configured pkg <- PackageIndex.allPackages index
+     , let packageProblems = configuredPackageProblems os arch comp pkg
+     , not (null packageProblems) ]
 
   ++ [ PackageMissingDeps pkg missingDeps
      | (pkg, missingDeps) <- PackageIndex.brokenPackages index ]





More information about the Cvs-libraries mailing list