[commit: base] : Improve comment on GHC.Event.Manager.closeFd_. (6bbb9fd)

Johan Tibell johan.tibell at gmail.com
Tue Feb 12 07:51:30 CET 2013


Repository : ssh://darcs.haskell.org//srv/darcs/packages/base

On branch  : 

http://hackage.haskell.org/trac/ghc/changeset/6bbb9fdadb834b930c9aea52c704e3eabd962324

>---------------------------------------------------------------

commit 6bbb9fdadb834b930c9aea52c704e3eabd962324
Author: Andreas Voellmy <andreas.voellmy at gmail.com>
Date:   Thu Jan 3 18:18:36 2013 +0100

    Improve comment on GHC.Event.Manager.closeFd_.
    
    Making this comment stand alone and not reference the comment on closeFd.

>---------------------------------------------------------------

 GHC/Event/Manager.hs |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/GHC/Event/Manager.hs b/GHC/Event/Manager.hs
index f6ba9b2..cb1eace 100644
--- a/GHC/Event/Manager.hs
+++ b/GHC/Event/Manager.hs
@@ -353,7 +353,7 @@ closeFd mgr close fd = do
         return (newMap, fds)
   forM_ fds $ \(FdData reg ev cb) -> cb reg (ev `mappend` evtClose)
 
--- | Does everything that closeFd does, except for updating the callback tables.
+-- | Close a file descriptor in a race-safe way. 
 -- It assumes the caller will update the callback tables and that the caller
 -- holds the callback table lock for the fd.
 closeFd_ :: EventManager -> IM.IntMap [FdData] -> Fd -> IO (IM.IntMap [FdData])





More information about the ghc-commits mailing list