<div dir="ltr">Got it. Will do.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Feb 18, 2013 at 8:10 PM, Simon Marlow <span dir="ltr"><<a href="mailto:marlowsd@gmail.com" target="_blank">marlowsd@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 18/02/13 17:38, Nicolas Frisby wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Moving all ticky bumps after the heapcheck did prevent the wiggling I<br>
noticed.<br>
Could you also weigh in on the location of the cost centre profiling<br>
entries?<br>
</blockquote>
<br></div>
The cost centre bumps should definitely be after the heap check too.<br>
<br>
Cheers,<br>
Simon<br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">
<br>
<br>
On Mon, Feb 18, 2013 at 2:19 PM, Simon Marlow <<a href="mailto:marlowsd@gmail.com" target="_blank">marlowsd@gmail.com</a><br></div><div><div class="h5">
<mailto:<a href="mailto:marlowsd@gmail.com" target="_blank">marlowsd@gmail.com</a>>> wrote:<br>
<br>
On 16/02/13 16:32, Nicolas Frisby wrote:<br>
<br>
I noticed some suspicious wiggling in my ticky reports' entry<br>
counts.<br>
SPJ suggested they were due to the counter ticking before the heap<br>
check: if it fails, then it ticks again when we re-enter after the<br>
stg_gc function does its thing.<br>
After looking into it a bit further, I have a couple questions.<br>
Here's<br>
what I found.<br>
* for functions (StgCmmBind.closureCodeBody), tickyEnterFun and<br>
enterCostCentreFun are before the heap check<br>
* for thunks (StgCmmBind.thunkCode), tickyEnterThunk is<br>
before the<br>
heap check and enterCostCentreThunk is after.<br>
Questions:<br>
* Does any object to me moving both ticky counters after the<br>
heap check?<br>
* Is there a reason the two cost centre profiling entries are on<br>
opposite sides of the heap check?<br>
<br>
<br>
It sounds wrong to me. If you could clean this up that would be<br>
great. These counters should never be bumped before the heap check,<br>
because if the heap check fails then the bumps will happen twice.<br>
<br>
Cheers,<br>
Simon<br>
<br>
<br>
</div></div></blockquote>
<br>
</blockquote></div><br></div>