<div dir="ltr"><div>Hi,<br><br>`Implemented getPageFaults for win32` breaks the build. The patch needs some more stuff added. I'll re-submit it soon-ish after I get it to build correctly.<br><br></div>Regards.<br></div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Apr 22, 2013 at 8:00 PM, <span dir="ltr"><<a href="mailto:ghc-devs-request@haskell.org" target="_blank">ghc-devs-request@haskell.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Send ghc-devs mailing list submissions to<br>
<a href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a><br>
<br>
To subscribe or unsubscribe via the World Wide Web, visit<br>
<a href="http://www.haskell.org/mailman/listinfo/ghc-devs" target="_blank">http://www.haskell.org/mailman/listinfo/ghc-devs</a><br>
or, via email, send a message with subject or body 'help' to<br>
<a href="mailto:ghc-devs-request@haskell.org">ghc-devs-request@haskell.org</a><br>
<br>
You can reach the person managing the list at<br>
<a href="mailto:ghc-devs-owner@haskell.org">ghc-devs-owner@haskell.org</a><br>
<br>
When replying, please edit your Subject line so it is more specific<br>
than "Re: Contents of ghc-devs digest..."<br>
<br>
<br>
Today's Topics:<br>
<br>
1. Re: [commit: ghc] master: Use ffi_prep_closure_loc rather<br>
than ffi_prep_closure (310735e) (Sergei Trofimovich)<br>
2. Re: [commit: ghc] master: Use ffi_prep_closure_loc rather<br>
than ffi_prep_closure (310735e) (Ian Lynagh)<br>
3. Re: Fwd: Implemented getPageFaults for win32 (Edward Z. Yang)<br>
<br>
<br>
----------------------------------------------------------------------<br>
<br>
Message: 1<br>
Date: Sun, 21 Apr 2013 21:34:31 +0300<br>
From: Sergei Trofimovich <<a href="mailto:slyich@gmail.com">slyich@gmail.com</a>><br>
Subject: Re: [commit: ghc] master: Use ffi_prep_closure_loc rather<br>
than ffi_prep_closure (310735e)<br>
To: <a href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a><br>
Cc: <a href="mailto:ghc-commits@haskell.org">ghc-commits@haskell.org</a><br>
Message-ID: <20130421213431.1b0ecc6c@sf><br>
Content-Type: text/plain; charset="us-ascii"<br>
<br>
> commit 310735e7adce0145c653386c21686b4a1b96aea9<br>
> Author: Ian Lynagh <<a href="mailto:ian@well-typed.com">ian@well-typed.com</a>><br>
> Date: Sun Apr 21 16:03:40 2013 +0100<br>
><br>
> Use ffi_prep_closure_loc rather than ffi_prep_closure<br>
><br>
> The latter is deprecated. Part of #7718.<br>
><br>
> >---------------------------------------------------------------<br>
><br>
> rts/Adjustor.c | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
> diff --git a/rts/Adjustor.c b/rts/Adjustor.c<br>
> index fbf95df..e4d6e8c 100644<br>
> --- a/rts/Adjustor.c<br>
> +++ b/rts/Adjustor.c<br>
> @@ -131,7 +131,7 @@ createAdjustor (int cconv,<br>
> barf("createAdjustor: failed to allocate memory");<br>
> }<br>
><br>
> - r = ffi_prep_closure(cl, cif, (void*)wptr, hptr/*userdata*/);<br>
> + r = ffi_prep_closure_loc(cl, cif, (void*)wptr, hptr/*userdata*/, code);<br>
> if (r != FFI_OK) barf("ffi_prep_closure failed: %d", r);<br>
<br>
The barf() text (/ffi_prep_closure/ffi_prep_closure_loc/) might be adjusted as well.<br>
<br>
> return (void*)code;<br>
<br>
--<br>
<br>
Sergei<br>
-------------- next part --------------<br>
A non-text attachment was scrubbed...<br>
Name: signature.asc<br>
Type: application/pgp-signature<br>
Size: 198 bytes<br>
Desc: not available<br>
URL: <<a href="http://www.haskell.org/pipermail/ghc-devs/attachments/20130421/111d0a11/attachment-0001.pgp" target="_blank">http://www.haskell.org/pipermail/ghc-devs/attachments/20130421/111d0a11/attachment-0001.pgp</a>><br>
<br>
------------------------------<br>
<br>
Message: 2<br>
Date: Sun, 21 Apr 2013 23:36:32 +0100<br>
From: Ian Lynagh <<a href="mailto:ian@well-typed.com">ian@well-typed.com</a>><br>
Subject: Re: [commit: ghc] master: Use ffi_prep_closure_loc rather<br>
than ffi_prep_closure (310735e)<br>
To: Sergei Trofimovich <<a href="mailto:slyich@gmail.com">slyich@gmail.com</a>><br>
Cc: <a href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a><br>
Message-ID: <<a href="mailto:20130421223632.GA3626@matrix.chaos.earth.li">20130421223632.GA3626@matrix.chaos.earth.li</a>><br>
Content-Type: text/plain; charset=us-ascii<br>
<br>
On Sun, Apr 21, 2013 at 09:34:31PM +0300, Sergei Trofimovich wrote:<br>
> > commit 310735e7adce0145c653386c21686b4a1b96aea9<br>
> ><br>
> > - r = ffi_prep_closure(cl, cif, (void*)wptr, hptr/*userdata*/);<br>
> > + r = ffi_prep_closure_loc(cl, cif, (void*)wptr, hptr/*userdata*/, code);<br>
> > if (r != FFI_OK) barf("ffi_prep_closure failed: %d", r);<br>
><br>
> The barf() text (/ffi_prep_closure/ffi_prep_closure_loc/) might be adjusted as well.<br>
<br>
Ta, fixed.<br>
<br>
<br>
Thanks<br>
Ian<br>
<br>
<br>
<br>
<br>
------------------------------<br>
<br>
Message: 3<br>
Date: Mon, 22 Apr 2013 01:20:08 -0700<br>
From: "Edward Z. Yang" <<a href="mailto:ezyang@MIT.EDU">ezyang@MIT.EDU</a>><br>
Subject: Re: Fwd: Implemented getPageFaults for win32<br>
To: Kyle Van Berendonck <<a href="mailto:kvanberendonck@gmail.com">kvanberendonck@gmail.com</a>><br>
Cc: ghc-devs <<a href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a>><br>
Message-ID: <1366618780-sup-7827@javelin><br>
Content-Type: text/plain; charset=UTF-8<br>
<br>
Hello Kyle,<br>
<br>
Could you please resend this patch; it looks like when you forwarded it<br>
it got linespace-wrapped inappropriately.<br>
<br>
Thanks,<br>
Edward<br>
<br>
Excerpts from Kyle Van Berendonck's message of Sun Apr 14 16:39:49 -0700 2013:<br>
> ---------- Forwarded message ----------<br>
> From: Kyle Van Berendonck <<a href="mailto:kvanberendonck@gmail.com">kvanberendonck@gmail.com</a>><br>
> Date: Sun, Apr 14, 2013 at 5:56 PM<br>
> Subject: Implemented getPageFaults for win32<br>
> To: <a href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a><br>
><br>
><br>
> Author: Kyle Van Berendonck <<a href="mailto:kvanberendonck@gmail.com">kvanberendonck@gmail.com</a>> 2013-04-14 17:45:39<br>
> Committer: Kyle Van Berendonck <<a href="mailto:kvanberendonck@gmail.com">kvanberendonck@gmail.com</a>> 2013-04-14<br>
> 17:45:39<br>
> Parent: 52efb2c8aefbd448e765e62a34c3e53ab7202a11 (No need to map over all<br>
> blocks, setting up PIC.)<br>
> Branch: master<br>
> Follows: ghc-darcs-git-switchover<br>
> Precedes:<br>
><br>
> Implemented getPageFaults for win32<br>
><br>
> ----------------------------- rts/win32/GetTime.c<br>
> -----------------------------<br>
> index bfab43a..50a2c4d 100644<br>
> @@ -157,6 +157,13 @@ W_<br>
> getPageFaults(void)<br>
> {<br>
> /* ToDo (on NT): better, get this via the performance data<br>
> - that's stored in the registry. */<br>
> + that's stored in the registry.<br>
> +<br>
> + nb: this includes the number of soft page faults, but it's better<br>
> than nothing<br>
> + */<br>
> + PROCESS_MEMORY_COUNTERS pmc;<br>
> + if (GetProcessMemoryInfo(GetCurrentProcess(), &pmc, sizeof(pmc))) {<br>
> + return pmc.PageFaultCount;<br>
> + }<br>
> return 0;<br>
> }<br>
<br>
<br>
<br>
------------------------------<br>
<br>
_______________________________________________<br>
ghc-devs mailing list<br>
<a href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a><br>
<a href="http://www.haskell.org/mailman/listinfo/ghc-devs" target="_blank">http://www.haskell.org/mailman/listinfo/ghc-devs</a><br>
<br>
<br>
End of ghc-devs Digest, Vol 116, Issue 39<br>
*****************************************<br>
</blockquote></div><br></div>