<div dir="ltr"><div><div><div>Hi Joachim,<br><br>I wouldn't know which place is preferable. Simon?<br><br></div>(Your snippet did remind me that I forgot to remove the -fwarn-typeable-instances flag...<br></div>working on that now.)<br>
<br><br></div>Thanks,<br>Pedro<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Sep 9, 2013 at 8:25 AM, Joachim Breitner <span dir="ltr"><<a href="mailto:mail@joachim-breitner.de" target="_blank">mail@joachim-breitner.de</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Dear Predro,<br>
<br>
Am Sonntag, den 08.09.2013, 18:27 -0500 schrieb Austin Seipp:<br>
> I know Pedro committed the work to make manual<br>
> Typeable instances an error, which is great.<br>
<br>
the Coercible class has a similar property, and I added the check to<br>
prevent manual instances to checkValidInstance in TcValidity:<br>
<a href="https://github.com/nomeata/ghc/commit/5e3f13" target="_blank">https://github.com/nomeata/ghc/commit/5e3f13</a><br>
while you did it in tcInstDecls1 in TcInstDecls:<br>
<a href="http://git.haskell.org/?p=ghc.git;a=commitdiff;h=5335e56953c4bbe18166039c06256e725f074b64" target="_blank">http://git.haskell.org/?p=ghc.git;a=commitdiff;h=5335e56953c4bbe18166039c06256e725f074b64</a><br>
<br>
I’m happy to follow suite if you tell me that TcInstDecls is indeed the<br>
better spot for such a check.<br>
<br>
Greetings,<br>
Joachim<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
Joachim “nomeata” Breitner<br>
<a href="mailto:mail@joachim-breitner.de">mail@joachim-breitner.de</a> • <a href="http://www.joachim-breitner.de/" target="_blank">http://www.joachim-breitner.de/</a><br>
Jabber: <a href="mailto:nomeata@joachim-breitner.de">nomeata@joachim-breitner.de</a> • GPG-Key: 0x4743206C<br>
Debian Developer: <a href="mailto:nomeata@debian.org">nomeata@debian.org</a><br>
</font></span><br>_______________________________________________<br>
ghc-devs mailing list<br>
<a href="mailto:ghc-devs@haskell.org">ghc-devs@haskell.org</a><br>
<a href="http://www.haskell.org/mailman/listinfo/ghc-devs" target="_blank">http://www.haskell.org/mailman/listinfo/ghc-devs</a><br>
<br></blockquote></div><br></div>