<div dir="ltr">Yes, ideally this would have been caught by a Windows build bot.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Dec 1, 2014 at 4:34 PM, Simon Peyton Jones <span dir="ltr"><<a href="mailto:simonpj@microsoft.com" target="_blank">simonpj@microsoft.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-GB" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif"">Indeed. But each bisect takes quite a while. So my attention switches and it takes a while to get back. I was hoping some machine might do it for me.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif""><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif"">Herbert suggested some commits to revert. I’ll try that first<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-family:"Calibri","sans-serif""><u></u> <u></u></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #e1e1e1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:11.0pt;font-family:"Calibri","sans-serif""> Johan Tibell [mailto:<a href="mailto:johan.tibell@gmail.com" target="_blank">johan.tibell@gmail.com</a>]
<br>
<b>Sent:</b> 01 December 2014 09:45<br>
<b>To:</b> Herbert Valerio Riedel<br>
<b>Cc:</b> <a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a>; Simon Marlow; Simon Peyton Jones<span class=""><br>
<b>Subject:</b> Re: Windows build broken again: urgent<u></u><u></u></span></span></p>
</div>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
<p>In general I think a good course of action when this happens is:<u></u><u></u></p><div><div class="h5">
<p>* Use git bisect to find the offending commit. This works now because we moved to submodules.<br>
* Revert the commit.<br>
* Push the patch to master and notify the author.<u></u><u></u></p>
<p>This style of early rollback will become more important as we grow as it puts the onus on fixing on the right person and minimizes negative impact on other developers.<u></u><u></u></p>
<div>
<p class="MsoNormal">On Dec 1, 2014 9:43 AM, "Herbert Valerio Riedel" <<a href="mailto:hvriedel@gmail.com" target="_blank">hvriedel@gmail.com</a>> wrote:<u></u><u></u></p>
<blockquote style="border:none;border-left:solid #cccccc 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal">Hello Simon,<br>
<br>
On 2014-12-01 at 09:38:37 +0100, Simon Peyton Jones wrote:<br>
> | Just a hunch... could it have been broken by one of the recent linker-<br>
> | related patches since Nov 24th?<br>
><br>
> That seems very plausible, yes. But still there's the question of<br>
> what to do about it.<br>
<br>
a) Empirically: Try locally 'git revert'ing<br>
<br>
383733b9191a36e2d3f757700842dbc3855911d9<br>
<br>
and/or<br>
<br>
b5e8b3b162b3ff15ae6caf1afc659565365f54a8<br>
<br>
and see if your problem goes away, or<br>
<br>
b) Ask Simon Marlow (he either wrote or reviewed those two patches) if<br>
he sees something odd in those patches that could have broken<br>
Windows' GHCi...<br>
<br>
Cheers,<br>
hvr<br>
_______________________________________________<br>
ghc-devs mailing list<br>
<a href="mailto:ghc-devs@haskell.org" target="_blank">ghc-devs@haskell.org</a><br>
<a href="http://www.haskell.org/mailman/listinfo/ghc-devs" target="_blank">http://www.haskell.org/mailman/listinfo/ghc-devs</a><u></u><u></u></p>
</blockquote>
</div>
</div></div></div>
</div>
</div>
</blockquote></div><br></div>