<div>Hi again,</div><div><br></div><div>I have run HLint against my libraries and found lots of suggestions, mainly excessive brackets.</div><div><br></div><div>This is what I suggest from my experience:</div>. a suggestion for a rule: dollar eta: f $ x -> f x<div>
. some parser errors I encountered: import Data.Generics hiding ((:*:))</div><div> type instance Rep Id x = x<br><br></div><div>Cheers,</div><div>hugo</div><div><br><div class="gmail_quote">
On Sat, Dec 20, 2008 at 10:21 AM, Hugo Pacheco <span dir="ltr"><<a href="mailto:hpacheco@gmail.com">hpacheco@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
I noticed that you convert point-wise into point-free.<div>Perhaps you could add some point-free transformations to remove redundancy in certain cases.</div><div>Is that a goal of the library?</div><div><br></div><div>Cheers,</div>
<div>hugo<div><div></div><div class="Wj3C7c"><br><br><div class="gmail_quote">On Sat, Dec 20, 2008 at 9:55 AM, Neil Mitchell <span dir="ltr"><<a href="mailto:ndmitchell@gmail.com" target="_blank">ndmitchell@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
I am pleased to announce HLint, a tool for making suggestions to<br>
improve your Haskell code. Previously this tool was called Dr Haskell<br>
and depended on a working installation of Yhc - both of those have now<br>
changed. HLint requires GHC 6.10*, and to install simply type:<br>
<br>
cabal update && cabal install hlint<br>
<br>
If you haven't yet installed the cabal command, instructions are here:<br>
<a href="http://ghcmutterings.wordpress.com/2008/11/10/bootstrapping-cabal-install/" target="_blank">http://ghcmutterings.wordpress.com/2008/11/10/bootstrapping-cabal-install/</a><br>
<br>
As an example of what HLint does, running "hlint darcs-2.1.2" over the<br>
latest stable release of darcs gives 385 suggestions, including:<br>
<br>
darcs-2.1.2\src\CommandLine.lhs:46:1: Use a string literal<br>
Found:<br>
[' ', '\t', '"', '%']<br>
Why not:<br>
" \t\"%"<br>
<br>
darcs-2.1.2\src\CommandLine.lhs:49:1: Eta reduce<br>
Found:<br>
quotedArg ftable<br>
= between (char '"') (char '"') $ quoteContent ftable<br>
Why not:<br>
quotedArg = between (char '"') (char '"') . quoteContent<br>
<br>
darcs-2.1.2\src\CommandLine.lhs:94:1: Use concatMap<br>
Found:<br>
concat $ map escapeC s<br>
Why not:<br>
concatMap escapeC s<br>
<br>
To see all the hints in a nice interactive document visit<br>
<a href="http://www-users.cs.york.ac.uk/~ndm/hlint/hlint-report.htm" target="_blank">http://www-users.cs.york.ac.uk/~ndm/hlint/hlint-report.htm</a><br>
(recommended if you are thinking of trying out hlint)<br>
<br>
All necessary links, including a manual, hackage links, bug tracker<br>
and source code can be found from the tool website:<br>
<a href="http://www-users.cs.york.ac.uk/~ndm/hlint/" target="_blank">http://www-users.cs.york.ac.uk/~ndm/hlint/</a><br>
<br>
Acknowledgements: Niklas Broberg and the haskell-src-exts package have<br>
both been very helpful. The darcs users mailing list gave many good<br>
suggestions which I've incorportated.<br>
<br>
Please direct any follow up conversations to haskell-cafe@<br>
<br>
Thanks<br>
<br>
Neil<br>
<br>
* Why GHC 6.10? View patterns.<br>
_______________________________________________<br>
Haskell mailing list<br>
<a href="mailto:Haskell@haskell.org" target="_blank">Haskell@haskell.org</a><br>
<a href="http://www.haskell.org/mailman/listinfo/haskell" target="_blank">http://www.haskell.org/mailman/listinfo/haskell</a><br>
</blockquote></div><br><br clear="all"><br></div></div>-- <br><a href="http://www.di.uminho.pt/~hpacheco" target="_blank">www.di.uminho.pt/~hpacheco</a><br>
</div>
</blockquote></div><br><br clear="all"><br>-- <br><a href="http://www.di.uminho.pt/~hpacheco">www.di.uminho.pt/~hpacheco</a><br>
</div>