Proposal: Allow gunfold for Data.Map, Data.IntMap, etc.

Milan Straka fox at ucw.cz
Thu Nov 22 09:18:52 CET 2012


Hi Edward,

> As the deadline has long since past and this appears to have been
> relatively non-controversial, what do we need to do to get these into
> containers?

the best way would be to create the patch and then create a pull request
at https://github.com/haskell/containers . Johan and me will be notified
then, will review the code and merge it.

Cheers,
Milan


> 
> -Edward
> 
> On Sat, Sep 1, 2012 at 8:23 AM, Edward Kmett <ekmett at gmail.com> wrote:
> 
> > For what it is worth, Milan already implemented the smarter fromList and
> > it is considerably faster. =)
> >
> > If I'm reading his numbers right, its ~50% faster than the original in the
> > worst case, and its about ~10x faster on large sorted inputs, and within 5%
> > of the speed of fromDistinctAscList.
> >
> > Overall, it is a huge win.
> >
> > -Edward
> >
> >
> > On Thu, Aug 30, 2012 at 9:50 AM, Brent Yorgey <byorgey at seas.upenn.edu>wrote:
> >
> >> On Wed, Aug 29, 2012 at 06:06:25PM -0700, Johan Tibell wrote:
> >> > On Wed, Aug 29, 2012 at 5:57 PM, Edward Kmett <ekmett at gmail.com> wrote:
> >> > > This might pay off as well, but I am leery that its a rather tricky
> >> > > balancing act and will take a lot of profiling to find the right
> >> balance in
> >> > > practical performance vs. asymptotic bounds.
> >> > >
> >> > > Should we split the notion of improving the performance of fromList
> >> into a
> >> > > separate project/proposal
> >> > > that simply exposes synergies with this one?
> >> >
> >> > Sure. Lets continue this thread on its original topic. I'm +1 on the
> >> > proposal.
> >>
> >> +1 from me too.  A smarter fromList also sounds cool but I agree that
> >> should be a separate proposal, if only to avoid derailing this one.
> >>
> >> -Brent
> >>
> >> _______________________________________________
> >> Libraries mailing list
> >> Libraries at haskell.org
> >> http://www.haskell.org/mailman/listinfo/libraries
> >>
> >
> >



More information about the Libraries mailing list