<div dir="ltr">On Wed, Jan 30, 2013 at 11:36 PM, Bas van Dijk <span dir="ltr"><<a href="mailto:v.dijk.bas@gmail.com" target="_blank">v.dijk.bas@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
The only function which could be controversial is:<br>
<br>
hash :: Hashable a => a -> Int<br>
<br>
since that function could give different results on different<br>
application runs when the environment variable HASHABLE_SALT is set to<br>
"random". However since this behavior is configurable and not the<br>
default I don't think it's an issue.<br><br>
<span class="HOEnZb"><font color="#888888"></font></span></blockquote></div><br>I think Johan is thinking of revisiting this issue for hashable 1.3 and reverting to the old behaviour. Hashable 1.2 also introduced some unfortunate performance regressions. My suggestion was to remove the randomized salt by default in favor of providing a "newtype RandomSalt a = RandomSalt a" for use in situations where guarding against hash collision attacks was important.<br clear="all">
<div><br></div><div>G</div>-- <br>Gregory Collins <<a href="mailto:greg@gregorycollins.net" target="_blank">greg@gregorycollins.net</a>>
</div></div>