<div dir="ltr"><div>I agree with Michael and Thomas,<br>+1 to including aeson as-is; if the ByteString instance is removed so much the better.<br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Sep 18, 2013 at 6:26 AM, Thomas Schilling <span dir="ltr"><<a href="mailto:nominolo@googlemail.com" target="_blank">nominolo@googlemail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I'm also +1, though I'd strongly prefer that the instance for<br>
ByteString gets dropped before inclusion.<br>
<br>
The "don't do that" approach is not very Haskelly. A Char8 ByteString<br>
is the same type as a Word8 ByteString, so while you could argue that<br>
Char8 is implicitly ASCII, the instance couldn't distinguish it from<br>
Word8 ByteStrings where this doesn't make sense. Since JSON doesn't<br>
have a standard way of encoding binary data<br>
(utf8/base64/base64url/...), external JSON API often may use their own<br>
convention, so it's best to require users to be explicit about<br>
semantics.<br>
<div class="HOEnZb"><div class="h5"><br>
On 18 September 2013 11:24, Herbert Valerio Riedel <<a href="mailto:hvr@gnu.org">hvr@gnu.org</a>> wrote:<br>
> On 2013-09-18 at 09:22:07 +0200, Michael Snoyman wrote:<br>
><br>
> [...]<br>
><br>
>> So: +1 from me on including aeson as-is, and if Bryan's interested in<br>
>> making this change to aeson, I'd consider it a perk.<br>
><br>
> +1 like Micheal<br>
><br>
> (i.e. I support `aeson` in HP unconditionally; but I'd be delighted if<br>
> the `ByteString` instances not pure issue would be fixed somehow)<br>
> _______________________________________________<br>
> Libraries mailing list<br>
> <a href="mailto:Libraries@haskell.org">Libraries@haskell.org</a><br>
> <a href="http://www.haskell.org/mailman/listinfo/libraries" target="_blank">http://www.haskell.org/mailman/listinfo/libraries</a><br>
_______________________________________________<br>
Libraries mailing list<br>
<a href="mailto:Libraries@haskell.org">Libraries@haskell.org</a><br>
<a href="http://www.haskell.org/mailman/listinfo/libraries" target="_blank">http://www.haskell.org/mailman/listinfo/libraries</a><br>
</div></div></blockquote></div><br></div>