<p>Writing this from my phone, so I'll be brief.</p>
<p>I'm OK with the name CIByteString, I just thought the Http would clarify that this is not safe for different encodings. But I can change this.</p>
<p>Parsing/rendering sounds like a good idea. I will probably use different function names, but you can set up aliases in wai-extra, right?</p>
<p>Headers are already there, no? You're confusing me.</p>
<p>Thanks for the nice feedback!<br></p>
<p>Aristid<br>
"sent from my Android"</p>
<p><blockquote type="cite">Am 04.02.2011 07:09 schrieb "Michael Snoyman" <<a href="mailto:michael@snoyman.com">michael@snoyman.com</a>>:<br><br>Alright, everything seems fine to me. Some more comments:<br>
<br>
* Besides the fact that I think HttpCIByteString is too verbose, it<br>
presents another problem: I cannot transparently switch over to it in<br>
WAI and http-enumerator. If you kept the same name (CIByteString), I<br>
could simply switch over to your version without any breaking changes.<br>
* I like methodGet et al.<br>
* Do you want to consider some parsing functions? I can provide you<br>
the code. Some things I would imagine would be:<br>
* parseQueryString :: ByteString -> [(ByteString, Maybe<br>
ByteString)] (I'm not sure if in practice anyone cares about the Maybe<br>
btw, but you are right that it is more theoretically correct)<br>
* renderQueryString :: [(ByteString, Maybe ByteString)] -> ByteString<br>
* parsePath :: ByteString -> [String], which would do all<br>
splitting-on-slash, percent decoding and UTF-8 decoding<br>
* renderPath :: [String] -> ByteString, which would be the reverse<br>
of parsePath<br>
* renderPathQuery :: [String] -> [(ByteString, ByteString)] -> ByteString<br>
* parseHttpAccept :: ByteString -> [ByteString]<br>
* Are you planning on adding headers as well?<br>
<br>
Basically, feel free to raid Network.Wai.Parse[1].<br>
<br>
[1] <a href="http://hackage.haskell.org/packages/archive/wai-extra/0.3.1/doc/html/Network-Wai-Parse.html" target="_blank">http://hackage.haskell.org/packages/archive/wai-extra/0.3.1/doc/html/Network-Wai-Parse.html</a><br>
<br>
On Fri, Feb 4, 2011 at 12:23 AM, Aristid Breitkreuz<br>
<p><font color="#500050"><<a href="mailto:aristidb@googlemail.com">aristidb@googlemail.com</a>> wrote:<br>> OK, I uploaded a fixed version:<br>> <a href="http://hackage.haskell.org/pack.">http://hackage.haskell.org/pack.</a>..</font></p>
</blockquote></p>