<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote">On 28 May 2013 03:47, Daniel Wagner <span dir="ltr"><<a href="mailto:wagnerdm@seas.upenn.edu" target="_blank">wagnerdm@seas.upenn.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">I've done my best to:<br>
* maintain backwards compatibility. Configs that use these symbols should generate a warning, but still work perfectly correctly.<br>
* ensure that all the places that used to export default values now also export "def", so that working configs can eliminate the warnings without changing their imports (or at worst change imports of defaultXPConfig, etc. to imports of def)<br>
<br></blockquote><div><br></div><div style>Seems that you have forgot to fix the warnings that this introduces? </div><div style>Anyways I'm getting the below warning when building from darcs. </div><div style><br></div>
<div style><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">XMonad/Core.hs:195:13:<br> Warning: This binding for `def' shadows the existing binding<br>
imported from `Data.Default' at XMonad/Core.hs:40:1-19</blockquote><div style><br></div><div style>The affected line 195, is the userCodeDef seen below:</div><div style><br></div><div style><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
-- | Execute the argument, catching all exceptions. Either this function or <br>
-- 'catchX' should be used at all callsites of user customized code. <br>
userCode :: X a -> X (Maybe a)<br>userCode a = catchX (Just `liftM` a) (return Nothing)<br>-- | Same as userCode but with a default argument to return instead of using <br>
-- Maybe, provided for convenience. <br>
userCodeDef :: a -> X a -> X a<br>userCodeDef def a = fromMaybe def `liftM` userCode a</blockquote><div><br></div></div><div style><br></div><div style>Would it make sense to have -Werror turned on by default, such that xmonad always compiles without warnings?</div>
<div style><br></div><div style>The reason why this is a problem is because I'm taking a new crack at fixing my updates to the old QC code such that it will compile against the darcs code instead of my own.</div><div style>
When compiling the test code, -Werror is turned on, which prevents me from compiling right now. Obviously I have fixed this locally for now.</div></div></div><div><br></div>-- <br><div dir="ltr">Reenberg<br></div>
</div></div>